Skip to content

impr(quotes): add English quotes (@lindseyp555) #7435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lindseyp555 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

impr(quotes): add English quotes (@lindseyp555) #7435

lindseyp555 wants to merge 4 commits into from
+18 −0

Conversation

@lindseyp555
Copy link

@lindseyp555 lindseyp555 commented Jan 23, 2026 •
edited
Loading

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 23, 2026
Leonabcd123
Leonabcd123 reviewed Jan 23, 2026
View reviewed changes
frontend/static/quotes/english.json Outdated
"length": 58
},
{
"text": "More than anything I was relieved that in my unfamiliar babbling-and-wanting-to-talk state I'd stopped myself from blurting the thing on the edge of my tongue, the thing I'd never said, even though it was something we both knew well enough without me saying it out loud to him in the street -- which was, of course, \"I love you.\"",
Copy link
Contributor

@Leonabcd123 Leonabcd123 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace -- with -.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 24, 2026
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Leonabcd123 Leonabcd123 Leonabcd123 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lindseyp555 @Leonabcd123 @monkeytypegeorge