fix: return false instead of nil for reference types, when value is false-y#26
Open
mzikherman wants to merge 1 commit intomongoid:masterfrom
Open
Conversation
Collaborator
|
Hello there! I think we need to do #27 before we start merging other changes. Maybe add Mongoid 8 support? Care to do that? |
Author
|
Yup, I can do that. I was noticing the lack of CI yesterday, I ran the spec suite locally but just with the specific version of Ruby/Mongoid I happened to be using and was curious to see the matrix run w/ multiple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticing an odd bug where if a field has
type: :referenceand thedefinitionis something that returnsfalse, the value ofnilgets returned instead of the correctfalse.👋 @dblock