-
Notifications
You must be signed in to change notification settings - Fork 31
[CLOUDP-361632] Add functionality to upload release info to GitHub release assets #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @MaciejKaras , @nammn @mircea-cosbuc @vinilage , thank you, sorry for the confusion. |
2f6ea42 to
f5fcd0d
Compare
MCK 1.6.1 Release NotesBug Fixes
Other Changes
|
d7108d6 to
f0a8b0f
Compare
| "digest": "sha256:ca4aad523f14d68fccb60256f9ce8909c66ebb5b321ee15e5abf9ac5738947f9" | ||
| }, | ||
| "agent": { | ||
| "repoURL": "quay.io/mongodb/mongodb-agent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've changed repositories from a slice to a string.
The agents are released - as of right now - to 2 different repositories, how would we reflect that now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! The idea is to share information only about main repository. The other repository we push agent to mongodb-agent-ubi is used for backward compatibility issue. Related comment -> https://github.com/mongodb/mongodb-kubernetes/pull/624/files#r2597674694
1. Use `docker run skopeo inspect` to get digest of manifest list of a container image instead of docker inspect 2. Write unit test
f449247 to
f2343ac
Compare
changelog/20251209_other_added_a_new_asset_in_github_releases_that_would.md
Outdated
Show resolved
Hide resolved
MaciejKaras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🤩
|
@nammn when you get some time, can you please have another look into this. |
vinilage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment proposing an improvement for the release notes.
changelog/20251209_other_added_a_new_asset_in_github_releases_that_would.md
Outdated
Show resolved
Hide resolved
| } | ||
| add_image_info(release_info_output, name, image.repository, image.platforms, operator_version) | ||
|
|
||
| # add OPS manager image info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep the comment everywhere or remove it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the comment to enterprise-server image.
| --- | ||
| kind: other | ||
| date: 2025-12-09 | ||
| --- | ||
|
|
||
| * Future releases will include a new asset, release_info_<version>.json, which provides detailed information about each MongoDB Controllers for Kubernetes release, including a clear list of all container images. This will help customers, especially those running in air-gapped environments, easily identify all required images for a given release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
As discussed in the base PR, customers have been asking us to provide some details that can be used to figure out the container images that they need to deploy a specific version of MCK and MongoDB instance.
This PR does that. It add the functionality to add a new file called
release_info_<release-version>.jsonto the GitHub release assets that would contain the details about MCK released images, OM, Agent, Search and the mapping between OM and agent's latest versions.This is how the file loos like
https://gist.github.com/viveksinghggits/560e6179a3c7d9b11b0df68f02b15ccc
Proof of Work
Run the patch manually
and make sure the new file is added to the release.
Screen.Recording.2025-12-02.at.23.00.35.mov
Screen.Recording.2025-12-02.at.23.08.27.mov
Checklist
skip-changeloglabel if not needed