PYTHON-5631 - test_direct_client_maintains_pool_to_arbiter waits inst…#2798
Open
NoahStapp wants to merge 1 commit intomongodb:masterfrom
Open
PYTHON-5631 - test_direct_client_maintains_pool_to_arbiter waits inst…#2798NoahStapp wants to merge 1 commit intomongodb:masterfrom
NoahStapp wants to merge 1 commit intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test_direct_client_maintains_pool_to_arbiter test to avoid a race by waiting until the arbiter’s pooled connection is actually present in the pool, instead of asserting immediately.
Changes:
- Replace a direct assertion on
len(arbiter.pool.conns)withwait_until(...)/async_wait_until(...)to reduce test flakiness. - Adjust the nearby comment to reflect the new “wait” behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_client.py | Makes the synchronous version of the test wait until the arbiter pool connection is registered before asserting. |
| test/asynchronous/test_client.py | Mirrors the same race-avoidance change for the asynchronous test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ead of asserting
PYTHON-5631
Changes in this PR
Have
test_direct_client_maintains_pool_to_arbiterwait until the pooled connection is registered rather than asserting immediately and risking a race.Test Plan
Test fix only.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer