PYTHON-5708 - Unskip large encryption tests on mongocryptd#2793
Open
NoahStapp wants to merge 3 commits intomongodb:masterfrom
Open
PYTHON-5708 - Unskip large encryption tests on mongocryptd#2793NoahStapp wants to merge 3 commits intomongodb:masterfrom
NoahStapp wants to merge 3 commits intomongodb:masterfrom
Conversation
NoahStapp
requested review from
aclark4life,
caseyclements and
Copilot
and removed request for
caseyclements
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a version-based skip that was preventing “large payload” client-side encryption prose tests from running when the server version is >= 7.0, restoring coverage for those scenarios (including mongocryptd-based setups).
Changes:
- Unskips the large-payload CSFLE corpus tests by removing
require_version_max(6, 99)fromTestCorpus. - Unskips the BSON size/batch-splitting CSFLE prose tests by removing
require_version_max(6, 99)fromTestBsonSizeBatches. - Applies the same unskip change to both synchronous and asynchronous encryption test suites.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/test_encryption.py |
Removes the server-version max requirement that was skipping large-payload encryption tests on newer server versions. |
test/asynchronous/test_encryption.py |
Mirrors the unskip change for the async encryption tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5708
Changes in this PR
See title.
Test Plan
Test sync only.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer