PYTHON-5756 - Fix BSON Binary type length bug#2790
Open
NoahStapp wants to merge 5 commits intomongodb:masterfrom
Open
PYTHON-5756 - Fix BSON Binary type length bug#2790NoahStapp wants to merge 5 commits intomongodb:masterfrom
NoahStapp wants to merge 5 commits intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix BSON binary-length validation in the C decoder so malformed Binary values are rejected correctly, and it adds a regression test in the BSON test suite.
Changes:
- Updates the Binary decoding path in
bson/_cbsonmodule.cto account for the element header when validating the remaining buffer length. - Adds
test_binary_length_accounts_for_headerto cover a malformed Binary payload that previously slipped through validation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
bson/_cbsonmodule.c |
Adjusts Binary element bounds checking in the C BSON decoder. |
test/test_bson.py |
Adds a regression test for malformed BSON Binary length handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5756
Changes in this PR
Fixes a bug in the C extension where BSON Binary fields did not correctly account for the header when calculating value length.
Test Plan
Added a new unit test
test_binary_length_accounts_for_header.Checklist
Checklist for Author
Checklist for Reviewer