-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5670 Restore minimal support for Python 3.9 #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jibola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
-> Do we need to test pypy3.10?
-> Bring back the drop 3.9 support ticket. (Just referencing this PR in it should suffice)
| ALL_VERSIONS = ["4.2", "4.4", "5.0", "6.0", "7.0", "8.0", "rapid", "latest"] | ||
| CPYTHONS = ["3.10", "3.11", "3.12", "3.13", "3.14t", "3.14"] | ||
| PYPYS = ["pypy3.11"] | ||
| MIN_SUPPORT_VERSIONS = ["3.9", "pypy3.9", "pypy3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to test against pypy3.10 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It felt odd to leave it out, putting it in the bucket of EoL versions that should still work.
|
|
||
|
|
||
| if sys.version_info >= (3, 10): | ||
| anext = builtins.anext | ||
| aiter = builtins.aiter | ||
| else: | ||
|
|
||
| async def anext(cls: Any) -> Any: | ||
| """Compatibility function until we drop 3.9 support: https://docs.python.org/3/library/functions.html#anext.""" | ||
| return await cls.__anext__() | ||
|
|
||
| def aiter(cls: Any) -> Any: | ||
| """Compatibility function until we drop 3.9 support: https://docs.python.org/3/library/functions.html#anext.""" | ||
| return cls.__aiter__() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make "Drop 3.9 support" a python ticket? (Or re-open it?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PYTHON-5670
Changes in this PR
Restores support for PyPy 3.9, PyPy 3.10, and Python 3.9.
Since all of these versions are EoL, we do not test against all scenarios.
Instead we test on
latestserver with the three standard combinations of topology, auth, and ssl.We only test on one platform.
Test Plan
Added a "Min Support RHEL8" variant with 9 tasks.
Passing build: https://spruce.mongodb.com/version/6938c98cb2efbb0007254ae8/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Checklist
Checklist for Author
Checklist for Reviewer