Skip to content

Add Windows CI testing#1935

Draft
vbabanin wants to merge 2 commits intomongodb:mainfrom
vbabanin:JAVA-6057
Draft

Add Windows CI testing#1935
vbabanin wants to merge 2 commits intomongodb:mainfrom
vbabanin:JAVA-6057

Conversation

@vbabanin
Copy link
Copy Markdown
Member

@vbabanin vbabanin commented Apr 9, 2026

  • Add Windows 2022 Evergreen build variants for server 8.2 across all topologies to enable Windows CI coverage
  • Add EnvironmentProvider class to centralize all System.getenv() calls, replacing the reflection-based env var override hack that fails on Windows due to JDK's ProcessEnvironment dual-map architecture
  • Fix SSL keystore/truststore paths in Evergreen scripts to use native Windows paths via cygpath
  • Fix JSON test file path separator handling and mongocryptd temp directory for Windows compatibility
  • Skip Unix-domain-socket test on Windows

JAVA-6057

- Add Windows 2022 Evergreen build variants for server 8.2 across all topologies to enable Windows CI coverage
- Add EnvironmentProvider class to centralize all System.getenv() calls, replacing the reflection-based env var override hack that fails on Windows due to JDK's ProcessEnvironment dual-map architecture
- Fix SSL keystore/truststore paths in Evergreen scripts to use native Windows paths via cygpath
- Fix JSON test file path separator handling and mongocryptd temp directory for Windows compatibility
- Skip Unix-domain-socket test on Windows

JAVA-6057
@vbabanin vbabanin self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Windows CI coverage and improves Windows compatibility across tests and Evergreen configuration by standardizing environment-variable access and fixing platform-specific path handling.

Changes:

  • Add Windows 2022 Evergreen build variants (server 8.2) and Windows-specific path handling in Evergreen scripts.
  • Introduce EnvironmentProvider to centralize env var access and enable test-time overrides without reflection hacks.
  • Fix Windows compatibility issues in tests (temp dirs, path separators) and skip a non-portable socket test on Windows.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java Write mongocryptd logs to Java temp dir for cross-platform support.
driver-sync/src/test/functional/com/mongodb/client/AbstractMicrometerProseTest.java Replace reflective env-var mutation with EnvironmentProvider overrides in micrometer prose tests.
driver-core/src/test/unit/com/mongodb/internal/EnvironmentProviderTest.java Add unit tests for env lookup/override behavior.
driver-core/src/test/functional/com/mongodb/internal/connection/SocketStreamHelperSpecification.groovy Skip a socket configuration test on Windows.
driver-core/src/test/functional/com/mongodb/internal/connection/FaasEnvironmentAccessor.java Remove test-only accessor for env overrides (superseded by EnvironmentProvider).
driver-core/src/test/functional/com/mongodb/internal/connection/ClientMetadataTest.java Update .dockerenv path to match production logic and be OS-correct.
driver-core/src/test/functional/com/mongodb/client/WithWrapper.java Switch env-var test wrapper to EnvironmentProvider.envOverride().
driver-core/src/main/com/mongodb/internal/observability/micrometer/TracingManager.java Use EnvironmentProvider.getEnv for observability env vars.
driver-core/src/main/com/mongodb/internal/observability/micrometer/MicrometerTracer.java Use EnvironmentProvider.getEnv for query text length env var.
driver-core/src/main/com/mongodb/internal/EnvironmentProvider.java New centralized env var provider + override mechanism for tests.
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java Read OIDC-related env vars via EnvironmentProvider.
driver-core/src/main/com/mongodb/internal/connection/FaasEnvironment.java Delegate env var reads to EnvironmentProvider (removing test override map).
driver-core/src/main/com/mongodb/internal/authentication/BuiltInAwsCredentialSupplier.java Read AWS env vars via EnvironmentProvider.
bson/src/test/unit/util/JsonPoweredTestHelper.java Normalize path separators to reliably locate JSON spec files on Windows.
.evergreen/setup-env.bash Add Windows-specific JDK paths for Evergreen.
.evergreen/run-tests.sh Use native Windows paths for SSL keystore/truststore and log Windows version.
.evergreen/run-csfle-tests-with-mongocryptd.sh Use native Windows paths for SSL keystore/truststore.
.evergreen/.evg.yml Add Windows axes/buildvariants and introduce MongoDB 8.2 for Windows coverage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread driver-core/src/main/com/mongodb/internal/EnvironmentProvider.java
Comment thread driver-core/src/main/com/mongodb/internal/EnvironmentProvider.java
Comment thread .evergreen/setup-env.bash
Comment on lines +8 to 16
else
export JDK8="/opt/java/jdk8"
export JDK11="/opt/java/jdk11"
export JDK17="/opt/java/jdk17"
export JDK21="/opt/java/jdk21"
fi
# note that `JDK21_GRAALVM` is used in `run-graalvm-native-image-app.sh`
# by dynamically constructing the variable name
export JDK21_GRAALVM="/opt/java/jdk21-graalce"
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, the JDK paths are switched to /cygdrive/c/..., but JDK21_GRAALVM remains hard-coded to a Linux path later in this script. If any Windows variants ever run the GraalVM native-image task, this will break. Consider applying the same OS switch for JDK21_GRAALVM (or documenting/enforcing that GraalVM tasks never run on Windows).

Suggested change
else
export JDK8="/opt/java/jdk8"
export JDK11="/opt/java/jdk11"
export JDK17="/opt/java/jdk17"
export JDK21="/opt/java/jdk21"
fi
# note that `JDK21_GRAALVM` is used in `run-graalvm-native-image-app.sh`
# by dynamically constructing the variable name
export JDK21_GRAALVM="/opt/java/jdk21-graalce"
# note that `JDK21_GRAALVM` is used in `run-graalvm-native-image-app.sh`
# by dynamically constructing the variable name
export JDK21_GRAALVM="/cygdrive/c/java/jdk21-graalce"
else
export JDK8="/opt/java/jdk8"
export JDK11="/opt/java/jdk11"
export JDK17="/opt/java/jdk17"
export JDK21="/opt/java/jdk21"
# note that `JDK21_GRAALVM` is used in `run-graalvm-native-image-app.sh`
# by dynamically constructing the variable name
export JDK21_GRAALVM="/opt/java/jdk21-graalce"
fi

Copilot uses AI. Check for mistakes.
Comment thread .evergreen/.evg.yml
Comment on lines +2568 to +2571
- matrix_name: "csfle-tests-with-mongocryptd-windows"
matrix_spec: { os: "windows",
version: [ "8.0", "latest" ],
topology: [ "replicaset" ] }
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above says MongoDB 8.0 binaries are affected on Windows and the fix is only available starting from 8.2, but this Windows CSFLE matrix still schedules version: [ "8.0", "latest" ]. This looks inconsistent and may cause avoidable Windows CI failures; consider using 8.2 here as well (or clarify why CSFLE is exempt).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants