Do various small timeout-related improvements#1908
Open
stIncMale wants to merge 1 commit intomongodb:mainfrom
Open
Do various small timeout-related improvements#1908stIncMale wants to merge 1 commit intomongodb:mainfrom
stIncMale wants to merge 1 commit intomongodb:mainfrom
Conversation
rozza
reviewed
Mar 11, 2026
| private static final int NO_ROUND_TRIP_TIME_MS = 0; | ||
| private final TimeoutSettings timeoutSettings; | ||
| /** | ||
| * Is {@code null} iff {@link #timeoutSettings}{@code .}{@link TimeoutSettings#getTimeoutMS() getTimeoutMS()} is {@code null}. |
Member
There was a problem hiding this comment.
This seems hard to understand / read. As we don't publish this as API docs would
Is {@code null} iff {@link #timeoutSettings} is {@code null}.
Suffice? Or is there some way to get the IntelliJ to display as javadoc by default rather than text?
rozza
approved these changes
Mar 11, 2026
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
One question about readability - but not a blocker.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.