fix(NODE-6642): include install script in published files#110
Open
axelonet wants to merge 1 commit intomongodb-js:mainfrom
Open
fix(NODE-6642): include install script in published files#110axelonet wants to merge 1 commit intomongodb-js:mainfrom
axelonet wants to merge 1 commit intomongodb-js:mainfrom
Conversation
PavelSafronov
added
External Submission
|
@axelonet , thanks for the PR! The team will look into this fix. |
There was a problem hiding this comment.
Pull request overview
Fixes a packaging issue in @mongodb-js/zstd where npm install ... --build-from-source could fail because the install script referenced a file that wasn’t included in the published tarball.
Changes:
- Adds
etc/install-zstd.shto thefilesallowlist so it is shipped in the npm package.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
7
to
13
| "files": [ | ||
| "index.d.ts", | ||
| "lib/index.js", | ||
| "addon/*", | ||
| "binding.gyp" | ||
| "binding.gyp", | ||
| "etc/install-zstd.sh" | ||
| ], |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Fix
npm install @mongodb-js/zstd --build-from-sourcefailing because the install script referenced a file that was not shipped in the tarballNotes for Reviewers
the install fallback path runs:
npm run clean-installnpm run install-zstdbash etc/install-zstd.shRelease Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript