Skip to content

Conversation

@blink1073
Copy link

@blink1073 blink1073 commented Dec 9, 2025

Description

  • Fix handling of keyFile: read/write cannot occur until user is added, and can never be done on an arbiter
  • Add support for requireApiVersion, which must be applied after the cluster has started and update the default connection options.
  • Allow args to be passed as part of the config file.
  • Only write the connection string to stdout, so it can be captured by the calling process

Tested with:

We didn't need to add extra support for unix sockets, instead we pass in the unix socket prefix.
I couldn't think of an elegant way to let mongodb-runner manage the keyFile, perhaps a new top level argument keyFileContent?

Open Questions

Checklist

@blink1073 blink1073 requested a review from addaleax December 9, 2025 13:18
@coveralls
Copy link

coveralls commented Dec 9, 2025

Coverage Status

coverage: 78.319% (+0.2%) from 78.084%
when pulling e8a3f1d on blink1073:drivers-tools-followup
into d2d12f3 on mongodb-js:main.

@addaleax addaleax changed the title DRIVERS-3335 Usability improvements for drivers feat(mongodb-runner): usability improvements for drivers DRIVERS-3335 Dec 9, 2025
@blink1073 blink1073 requested a review from addaleax December 22, 2025 18:20
@blink1073
Copy link
Author

After struggling a bit with Windows and a failed attempt to test with OIDC, this is ready for review. 😅

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version LGTM from my side but given that I've changed quite a bit I wouldn't merge this until @blink1073 can take another look (and only if CI is green, of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants