-
Notifications
You must be signed in to change notification settings - Fork 1
fix(monad): exclude blob suites from MONAD_EIGHT #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: forks/monad_eight
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,8 @@ | |
| REFERENCE_SPEC_GIT_PATH = ref_spec_4844.git_path | ||
| REFERENCE_SPEC_VERSION = ref_spec_4844.version | ||
|
|
||
| pytestmark = pytest.mark.valid_for_blob_forks() | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. KZG precompile tests incorrectly excluded from MONAD_EIGHT The Since MONAD_EIGHT explicitly retains the KZG precompile (documented in forks.py line 2358: "Monad keeps the point-evaluation precompile"), these tests should remain valid for that fork. Same issue in: Recommendation: Either remove the
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bot has a point here (and next file too) |
||
|
|
||
|
|
||
| class Result(str, Enum): | ||
| """Result of the point evaluation precompile.""" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,8 @@ | |
| REFERENCE_SPEC_GIT_PATH = ref_spec_4844.git_path | ||
| REFERENCE_SPEC_VERSION = ref_spec_4844.version | ||
|
|
||
| pytestmark = pytest.mark.valid_for_blob_forks() | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. KZG precompile gas tests incorrectly excluded from MONAD_EIGHT Same issue as in See also: |
||
|
|
||
|
|
||
| @pytest.fixture | ||
| def precompile_input(proof: Literal["correct", "incorrect"]) -> bytes: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure, but if you switch target to
forks/monad_nine, these diffs should be gone.