Initialize Cramér-von Mises test#42
Open
RobbeBohy wants to merge 6 commits into
Open
Conversation
tovrstra
reviewed
May 21, 2026
Member
tovrstra
left a comment
There was a problem hiding this comment.
Just some minor suggestions below and a few general ones here:
- I would remove the
_listsuffixes of the variables names. The naming conventions I've used so far is somewhat fortranic, but works well in Python too: If a variable or an array represents a count of some sort, then prefix it withn(short for number of). If a variable is a list or array, add anssuffix (plural). Most people inuitively use anssuffix for both, which makes sense in a natural language, but does not work as a naming convention. Adding_listor_arrayinstead ofsis also common, but goes a bit against Python's duck typing idea. - I've tested the code checked the plots. It all looks clear. It may be helpful to add the "p-value of the p-values somewhere on or above the bottom panel. (There may be better names for this thing.)
| unzipped_kernel = np.load(path_kernel) | ||
| acf = unzipped_kernel[acf_path] | ||
|
|
||
| pool = [[] for _ in range(len(dt_list))] |
Member
There was a problem hiding this comment.
Minor suggestion: It would be more Pythonic to combine dts and pool into a single dictionary.
Collaborator
Author
There was a problem hiding this comment.
Good idea, I refactored this in 902d772.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR introduces the first component of the new
3_validationworkflow, as discussed in #27, and includes: