Conversation
|
LGTM. I let @xavierfoucrier take a look too. |
|
Hello @babu-ch 👋 Thanks for opening a PR for that, I will need to check before merging of course. Thanks for tagging me @Sandstedt 😎 😽 |
|
Hello 👋 shall we upgrade directly to v24 (it's in active LTS now)? Cheers 🍻 |
|
Trying to do my best this year, since I am father again.. it's a bit complicated at some point. |
|
If v24 works fine, I can update this PR to bump the version to v24 as well. |
|
I prefer checking and doing it myself, because the mojs/core library is used in many other repos that I will need to update and check too, not only public repos. Thanks for the PR 😉 |
Quelle belle nouvelle! Félicitations Xavier! |
resolves #279
I also created a PR for
mojs-playermojs/mojs-player#23