fix(product): cast publish_document to int in create controller#160
Open
Ibochkarev wants to merge 2 commits intobetafrom
Open
fix(product): cast publish_document to int in create controller#160Ibochkarev wants to merge 2 commits intobetafrom
Ibochkarev wants to merge 2 commits intobetafrom
Conversation
Ensures publish_document is consistently cast to (int) in the JS config, matching the same pattern used for canSave and show_tvs.
Add handleCheckBoxes() with setCheckbox('hide_children_in_tree') in
Category/Update and Category/Create so the setting is saved correctly.
Fixes #161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Приведение
publish_documentк(int)в JS-конфиге контроллера создания продукта для консистентности типов. РанееcanPublishпередавалось без явного приведения к целому числу, тогда как аналогичные поляcanSaveиshow_tvsуже приводились к(int).Тип изменений
Связанные Issues
Нет
Как это было протестировано?
Конфигурация тестирования:
Скриншоты (если применимо)
Не применимо — изменение касается только приведения типа.
Чеклист
Дополнительные заметки
Однострочное изменение: добавлено
(int)перед$this->canPublishв массиве$ready(строка 135), чтобы JavaScript гарантированно получал числовое значение, как это уже делается дляcanSaveиshow_tvs.