Update SASS syntax#184
Conversation
fix: Precision variation on calc of step
| $global-settings: _get-global-settings(); | ||
|
|
||
| // let's avoid modifying the provided $settings map directly | ||
| $combined-settings: map.deep-merge((), $settings); |
There was a problem hiding this comment.
I should NOT remove these default settings, set by @scottkellum !
| /// round-to(3.14159, 2) // 3.14 | ||
| /// round-to(2.6999999999999997em, 2) // 2.7em | ||
| /// round-to(41.052552223205566px, 2) // 41.05px | ||
| /// round-to(0.8888888888888888, 4) // 0.8889 |
There was a problem hiding this comment.
I wasn't aware there's no precision rounding in sass.
I've seen you covered it with tests already which is nice! 👍🏻
| @use '../modularscale/round-to' as *; | ||
|
|
||
|
|
||
| @include true.describe('round-to [function]') { |
There was a problem hiding this comment.
It might be worth checking for largest number for some specific cases where someone applies very large margin.
math.$max-number
is specified to be 179769313486231570000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 but safest integer is just 9007199254740991.
I may be worrying too much into the future but it might be something worth attention. LMK @robsonsobral
| "homepage": "https://www.modularscale.com", | ||
| "dependencies": { | ||
| "sass": "^1.34.0" | ||
| "sass": "^1.94.2" |
There was a problem hiding this comment.
Very glad to see this as a side-effect of the changes <3
| $base-length: list.length($base); | ||
| $bases: (); | ||
|
|
||
| // Resolve named ratio from settings map (e.g. ratio: 'minor-second') |
robsonsobral
left a comment
robsonsobral
left a comment
There was a problem hiding this comment.
Fixing #176
3 participants
No changes besides updates on syntax.
Please, take a look, @Lukortech .