Open
Conversation
Add a skill capturing patterns and pitfalls for contributing to the Mojo standard library, distilled from 30+ reviewed PRs. Covers process, assertion semantics, optimization verification with compile_info, benchmarks, testing, SIMD safety, and Writable trait patterns. Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Maintainer review cycles are expensive. The skill should instruct the agent to ask the human to review the diff, PR description, and benchmarks before converting from draft to ready for review. Signed-off-by: Manuel Saelices <msaelices@gmail.com>
- Use standard editorial comment template from other skills - Add opening paragraph consistent with mojo-syntax/gpu-fundamentals - Remove content duplicated from mojo-syntax (Writable basics, deprecated APIs, comptime vs @parameter, move semantics) - Remove general git/build commands already in CLAUDE.md - Consolidate compile_info section, cut niche bullets - Merge changelog into process section - Reorder: process, assertions, optimizations, design, benchmarks, testing, SIMD, writable - Reduce from 169 to 111 lines (34% smaller) Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a skill for contributing to the Mojo standard library, distilled from 30+ reviewed PRs. Covers:
assert_mode="safe"table)compile_infoand benchmarksblack_box/keep, setup outside hot loop)Some[Writer],FormatStruct)Assisted-by: AI