-
Notifications
You must be signed in to change notification settings - Fork 290
Propose to improve p03
#204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… solution files, and refine puzzle 03 documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request makes minor documentation and code improvements to puzzle 03, focusing on fixing typos, updating links, and removing unused imports.
Changes:
- Fixed spelling error from "Undefined Behavoirs" to "Undefined Behaviors"
- Updated documentation link to be more specific (pointing to
introduction_layout_tensor.mdinstead of the directory) - Removed unused
UnsafePointerimport from both problem and solution files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| book/src/puzzle_03/puzzle_03.md | Fixed typo and updated LayoutTensor documentation link |
| problems/p03/p03.mojo | Removed unused import |
| solutions/p03/p03.mojo | Removed unused import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnsafePointer used in typehint in the fucntion add_10_gaurd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also problem section too.
ehsanmok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tolga! similar to #201 please keep the UnsafePointer import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ehsanmok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks.
|
Thanks for merging! |
Thanks a lot for this implementation-based learning environment!