-
Notifications
You must be signed in to change notification settings - Fork 340
Propose to improve p01 and p02
#201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| from memory import UnsafePointer | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We didn't need to import
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even if it's built-in, I think explicitly importing it is still helpful.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with Devin Review's comment: "Pedagogical clarity: For beginners, fewer imports = less cognitive overhead."
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a valid perspective. However, I believe beginners could actually experience confusion about where these constructs originate. Those encountering this for the first time are likely new to Mojo entirely. If something isn't a reserved keyword, making its provenance explicit should aid understanding. |
||
| from gpu import thread_idx, block_dim, block_idx | ||
| from gpu import thread_idx | ||
| from gpu.host import DeviceContext | ||
|
tolgacangoz marked this conversation as resolved.
|
||
| from testing import assert_equal | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.