Conversation
|
@winding-lines Could you add CodeQL to your repo? You can follow the instructions here https://docs.github.com/en/code-security/code-scanning/enabling-code-scanning/configuring-default-setup-for-code-scanning. Then add the badge to your README.md: This is something that Modular has asked for from any projects that are not Mojo only. |
|
Thanks @sstadick , enabled CodeQL and added the badge. |
|
|
||
| requirements: | ||
| build: | ||
| - mojo |
There was a problem hiding this comment.
suggestion(non-blocking): for future versions, update this to mojo-compiler as it's a lighter dep, and also concider pinning the mojo version. Example: https://github.com/modular/modular-community/blob/main/recipes/emberjson/recipe.yaml
|
And the package upload failed with the exact issue you pointed out in the forum. I'll look into this tomorrow and see if it's fixable by us(community), or if we need modular. I thought we'd resolved this once already. |
|
Following up for completeness: The ci job from the merge into master failed because the Pontoneer package failed to build and CI tried to add it to the failed deps list (which doesn't work at the moment since CI can't push to master). #224 is open to fix the Pontoneer package |
Checklist
recipe.yamlfile specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.0(for new packages, or if the version changed).