Skip to content

fix: normalize copied full paths across platforms #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kilaparthi-Himanshu wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: normalize copied full paths across platforms #6101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/ui/src/layouts/shared/files-tab/components/FileContextMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,11 @@ function getFullPath() {
if (!currentItem.value) return ''
const basePath = ctx.basePath?.value
const itemPath = currentItem.value.path
return basePath ? `${basePath}/${itemPath}`.replace(/\/+/g, '/') : itemPath
if (!basePath) return itemPath
const fullPath = `${basePath}/${itemPath}`
return navigator.userAgent.includes('Windows')
? fullPath.replace(/[\\/]+/g, '\\')
: fullPath.replace(/[\\/]+/g, '/')
}

function handleCopyPath() {
Expand Down
6 changes: 5 additions & 1 deletion packages/ui/src/layouts/shared/files-tab/components/FileTableRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,11 @@ const isZip = computed(() => fileExtension.value === 'zip')

function getFullPath() {
const basePath = ctx.basePath?.value
return basePath ? `${basePath}/${props.path}`.replace(/\/+/g, '/') : props.path
if (!basePath) return props.path
const fullPath = `${basePath}/${props.path}`
return navigator.userAgent.includes('Windows')
? fullPath.replace(/[\\/]+/g, '\\')
: fullPath.replace(/[\\/]+/g, '/')
}

const menuOptions = computed(() => {
Expand Down