fix(query): set default query retry to 1#5743
Open
IsQuyet wants to merge 2 commits intomodrinth:mainfrom
Open
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Member
|
This is good but it probably isn't the right solution, we should instead configure tanstack to stop retrying if it's a 404 response |
Contributor
Author
Of course, I also think conditional expressions would be better, and I will modify them later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5450
The query is automatically retried by default (retry = 3), and currently it will make requests to versions v2 and v3 in parallel. This results in two sets of requests, with each set making 4 requests, for a total of 8 requests. This is why the 404 page takes a while to appear.
Since I was unable to reproduce the issue on my local development server, I verified that the changes were effective by overriding the obfuscated code of the website locally in my browser.
Setting retry to false directly will be the fastest, but the specific value should be determined by someone who understands the impact better.