Skip to content

Conversation

@lumiscosity
Copy link
Contributor

@lumiscosity lumiscosity commented Jan 10, 2026

This should lighten the cost of the i18n infra a little. Marking as draft until I test as much of it as I can. Some notes apply:

  • There are a few new entries in commonMessages - some are to address existing duplicate use cases, while some simply contain common strings that could be reused elsewhere in the future (or are used in other places which aren't translatable at the moment).
  • The translation key for commonMessages.privateLabel is now label.private instead of collections.label.private for consistency.
  • All entries in paymentMethodMessages are now in the payment-method namespace. paymentMethodCardDisplay has also been moved from commonMessages to paymentMethodMessages.
  • There is a lot of duplication within common-messages.ts itself, particularly between commonMessages and formFieldLabels, that this PR does not currently address.
  • The landing page has some duplicates in the Modrinth UI mockups. I'm not sure how to best deal with exposing the translation keys from the proper source for these so I'm considering this out of scope for this PR. Other duplicates of common messages on the landing page are adressed.
  • privateLabel, publicLabel and rejectedLabel are currently skipped, since they would need adjustment for grammatical gender in some languages. Ideally these should be split into project and collection labels; going deeper into project types would create a lot of duplication but technically be more proper...
  • There's a lot of very definition intertangled reuse of "Server", independently or in relation to "Client" ("Server and client" appears multiple times!). I'll adress this in a separate PR when unifying the translation keys for sidedness strings sitewide. This also affects singleplayerLabel.

@lumiscosity lumiscosity force-pushed the deduplicate-common-strings branch from 1f877f8 to 114bc5d Compare January 11, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant