Deduplicate common strings in translation #5085
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should lighten the cost of the i18n infra a little. Marking as draft until I test as much of it as I can. Some notes apply:
commonMessages- some are to address existing duplicate use cases, while some simply contain common strings that could be reused elsewhere in the future (or are used in other places which aren't translatable at the moment).commonMessages.privateLabelis nowlabel.privateinstead ofcollections.label.privatefor consistency.paymentMethodMessagesare now in thepayment-methodnamespace.paymentMethodCardDisplayhas also been moved fromcommonMessagestopaymentMethodMessages.common-messages.tsitself, particularly betweencommonMessagesandformFieldLabels, that this PR does not currently address.privateLabel,publicLabelandrejectedLabelare currently skipped, since they would need adjustment for grammatical gender in some languages. Ideally these should be split intoprojectandcollectionlabels; going deeper into project types would create a lot of duplication but technically be more proper...singleplayerLabel.