Skip to content

Make Maven file resolution case-insensitive #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zefir-git wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Make Maven file resolution case-insensitive #4917

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb3aee7
Make Maven file resolution case-insensitive
zefir-git Dec 16, 2025
9d8f0c1
Merge branch 'main' into maven-case-insensitive
zefir-git Dec 16, 2025
17edcfe
Merge branch 'main' into maven-case-insensitive
zefir-git Dec 17, 2025
063c734
Merge branch 'main' into maven-case-insensitive
zefir-git Dec 19, 2025
45f34fb
fix string reference
zefir-git Dec 19, 2025
81860bc
Merge branch 'main' into maven-case-insensitive
Prospector Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/labrinth/src/routes/maven.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,11 @@
fn find_file<'a>(
project_id: &str,
vcoords: &str,
version: &'a VersionQueryResult,

Check warning on line 241 in apps/labrinth/src/routes/maven.rs

View workflow job for this annotation

GitHub Actions / Lint and Test 

Diff in /home/runner/work/code/code/apps/labrinth/src/routes/maven.rs
file: &str,
) -> Option<&'a FileQueryResult> {
if let Some(selected_file) =
version.files.iter().find(|x| x.filename == file)
version.files.iter().find(|x| x.filename.eq_ignore_ascii_case(file))
{
return Some(selected_file);
}
Expand All @@ -256,10 +256,10 @@
"modpack" => fileexts.push("mrpack"),
_ => (),
}
}

Check warning on line 259 in apps/labrinth/src/routes/maven.rs

View workflow job for this annotation

GitHub Actions / Lint and Test 

Diff in /home/runner/work/code/code/apps/labrinth/src/routes/maven.rs

for fileext in fileexts {
if file == format!("{}-{}.{}", &project_id, &vcoords, fileext) {
if file.eq_ignore_ascii_case(&format!("{}-{}.{}", &project_id, &vcoords, fileext)) {
return version
.files
.iter()
Expand Down Expand Up @@ -313,7 +313,7 @@
return Err(ApiError::NotFound);
}

if file == format!("{}-{}.pom", &project_id, &vnum) {
if file.eq_ignore_ascii_case(&format!("{}-{}.pom", &project_id, &vnum)) {
let respdata = MavenPom {
schema_location:
"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
Expand Down
Loading