Convert projects to Storybook v9#3039
Conversation
🦋 Changeset detectedLatest commit: 1d184cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "lit": "^2.7.5 || ^3.0.0", | ||
| "msw": "2.4.1" | ||
| "msw": "2.4.1", | ||
| "storybook": "9.1.19" |
There was a problem hiding this comment.
this would mean a major, since this package now doesn't support 7 & 8
but upgrading the mocks package to new major as a result of the storybook plugin seems like a wrong idea
I'd do the following:
- keep the package as is
- make a new package
@web/storybook-addon-mocksand make it compatible with Storybook 9 only (ditch "storybook-prebuilt") - deprecate existing plugins in
web/mocks - one challenge is versioning: I think mocks depends both on
mswand onstorybook, so we won't be able to sync a version with both of them, therefore best not to try to sync it and do our own versioning for it, starting with 1.x.x - documentation should be updated with all necessary deprecations, migrations and such
There was a problem hiding this comment.
on a 2nd thought: Storybook packages are in deps
if we keep this package as is, then older Storybook versions will always be installed
so we'll have to make a new major of this package anyway to decouple it from Storybook for good
| '@storybook/addon-interactions', | ||
| '@storybook/addon-a11y', | ||
| '@web/mocks/storybook-addon', | ||
| '@storybook/addon-docs', |
There was a problem hiding this comment.
nitpick: please move it to the top of the list where essentials was
| "@web/rollup-plugin-import-meta-assets": "^2.2.1", | ||
| "@web/storybook-utils": "^1.1.0", | ||
| "storybook": "^8.6.15" | ||
| "storybook": "9.1.19" |
There was a problem hiding this comment.
there is no caret in these deps
2 participants
What I did