Improve assets handling #3011
Merged
Improve assets handling #3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b00f8fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bashmish
commented
Dec 23, 2025
bashmish
commented
Dec 23, 2025
| rollupPluginHTML({ | ||
| input: { html: await generateIframeHtml(options), name: 'iframe.html' }, | ||
| extractAssets: true, | ||
| bundleAssetsFromCss: true, |
Member
Author
There was a problem hiding this comment.
I think I can't make a release of storybook-builder in this PR, because it's unrelated, but due to tight coupling in the monorepo, I had to remove this option in here to prevent TS errors
therefore I'll make sure to create a follow-up PR to update the storybook-builder right after this PR is merged and 3.x.x is released
thepassle
approved these changes
Dec 24, 2025
bashmish
force-pushed
the
feat/improve-assets-handling
branch
from
26e4e0d to
a07c36e
Compare
bashmish
force-pushed
the
feat/improve-assets-handling
branch
from
051ad6e to
72ea214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2152
What I did
See MIGRATION.md for migration notes.