-
Notifications
You must be signed in to change notification settings - Fork 50
docs(readme): add critique to feature comparison
#249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,17 +84,17 @@ For the full live-session and `--agent-context` workflow guide, see [docs/agent- | |
|
|
||
| ## Feature comparison | ||
|
|
||
| | Capability | [hunk](https://github.com/modem-dev/hunk) | [lumen](https://github.com/jnsahaj/lumen) | [difftastic](https://github.com/Wilfred/difftastic) | [delta](https://github.com/dandavison/delta) | [diff-so-fancy](https://github.com/so-fancy/diff-so-fancy) | [diff](https://www.gnu.org/software/diffutils/) | | ||
| | ---------------------------------- | ----------------------------------------- | ----------------------------------------- | --------------------------------------------------- | -------------------------------------------- | ---------------------------------------------------------- | ----------------------------------------------- | | ||
| | Review-first interactive UI | β | β | β | β | β | β | | ||
| | Multi-file review stream + sidebar | β | β | β | β | β | β | | ||
| | Inline agent / AI annotations | β | β | β | β | β | β | | ||
| | Responsive auto split/stack layout | β | β | β | β | β | β | | ||
| | Mouse support inside the viewer | β | β | β | β | β | β | | ||
| | Runtime view toggles | β | β | β | β | β | β | | ||
| | Syntax highlighting | β | β | β | β | β | β | | ||
| | Structural diffing | β | β | β | β | β | β | | ||
| | Pager-compatible mode | β | β | β | β | β | β | | ||
| | Capability | [hunk](https://github.com/modem-dev/hunk) | [critique](https://github.com/remorses/critique) | [lumen](https://github.com/jnsahaj/lumen) | [difftastic](https://github.com/Wilfred/difftastic) | [delta](https://github.com/dandavison/delta) | [diff-so-fancy](https://github.com/so-fancy/diff-so-fancy) | [diff](https://www.gnu.org/software/diffutils/) | | ||
| | ---------------------------------- | ----------------------------------------- | ------------------------------------------------ | ----------------------------------------- | --------------------------------------------------- | -------------------------------------------- | ---------------------------------------------------------- | ----------------------------------------------- | | ||
| | Review-first interactive UI | β | β | β | β | β | β | β | | ||
| | Multi-file review stream + sidebar | β | β | β | β | β | β | β | | ||
| | Inline agent / AI annotations | β | β | β | β | β | β | β | | ||
| | Responsive auto split/stack layout | β | β | β | β | β | β | β | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The PR description itself flags this as uncertain: Prompt To Fix With AIThis is a comment left during a code review.
Path: README.md
Line: 92
Comment:
**Potentially inaccurate β for "Inline agent / AI annotations"**
The PR description itself flags this as uncertain: `critique` has an AI review feature (per its own README), which may warrant a β
here. The distinction worth pinning down is whether the comparison row covers AI-generated annotations surfaced inline in the diff viewer β if `critique` does this, the cell should be β
.
How can I resolve this? If you propose a fix, please make it concise. |
||
| | Mouse support inside the viewer | β | β | β | β | β | β | β | | ||
| | Runtime view toggles | β | β | β | β | β | β | β | | ||
| | Syntax highlighting | β | β | β | β | β | β | β | | ||
| | Structural diffing | β | β | β | β | β | β | β | | ||
| | Pager-compatible mode | β | β | β | β | β | β | β | | ||
|
|
||
| Hunk is optimized for reviewing a full changeset interactively. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR author notes
critiquesupports multi-file review streaming but lacks a sidebar. If the row's intent is the full combination (stream and sidebar), β is correct. If "sidebar" is a separable sub-feature, a β with a footnote or the row being split would be more accurate. Worth a quick decision from the maintainer before merging.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!