[model] support kimi-k2.5 transformers & megatron#8239
[model] support kimi-k2.5 transformers & megatron#8239Jintao-Huang wants to merge 2 commits intomodelscope:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for the 'kimi-k2.5' model across the system. It involves updating various model type enumerations and architectural definitions to properly recognize and handle this new transformer model, ensuring its compatibility with both general model functionalities and Megatron-specific implementations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for the kimi-k2.5 model. The changes involve updating model type enumerations and configurations in several files. The additions are consistent with existing patterns. I've provided a suggestion to improve maintainability by sorting a set of model types.
| 'qwen2_moe', 'qwen3_moe', 'deepseek_v2', 'deepseek_v3', 'kimi_k2', 'dots1', 'ernie4_5_moe', 'glm4_moe', | ||
| 'glm4_moe_lite', 'glm4v_moe', 'minimax_m2', 'olmoe', 'qwen3_next', 'kimi_vl', 'qwen3_omni_moe', | ||
| 'qwen3_5_moe', 'glm_moe_dsa', 'deepseek_v32' | ||
| 'qwen3_5_moe', 'glm_moe_dsa', 'deepseek_v32', 'kimi_k25' |
There was a problem hiding this comment.
For better readability and easier maintenance, please consider keeping the model types in this set sorted alphabetically.
| 'qwen2_moe', 'qwen3_moe', 'deepseek_v2', 'deepseek_v3', 'kimi_k2', 'dots1', 'ernie4_5_moe', 'glm4_moe', | |
| 'glm4_moe_lite', 'glm4v_moe', 'minimax_m2', 'olmoe', 'qwen3_next', 'kimi_vl', 'qwen3_omni_moe', | |
| 'qwen3_5_moe', 'glm_moe_dsa', 'deepseek_v32' | |
| 'qwen3_5_moe', 'glm_moe_dsa', 'deepseek_v32', 'kimi_k25' | |
| 'deepseek_v2', 'deepseek_v3', 'deepseek_v32', 'dots1', 'ernie4_5_moe', 'glm4_moe', | |
| 'glm4_moe_lite', 'glm_moe_dsa', 'glm4v_moe', 'kimi_k2', 'kimi_k25', 'kimi_vl', | |
| 'minimax_m2', 'olmoe', 'qwen2_moe', 'qwen3_5_moe', 'qwen3_moe', 'qwen3_next', 'qwen3_omni_moe' |
No description provided.