fix: change deprecated registry and remove unused probes

[aagumin]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @aagumin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on essential maintenance and updates for the model-csi-driver chart. It addresses the deprecation of the k8s.gcr.io image registry by migrating to registry.k8s.io for the csi-node-driver-registrar component. Concurrently, the csi-node-driver-registrar is upgraded to a newer version, and unnecessary health probes are removed from the daemonset configuration, leading to a cleaner and more up-to-date deployment.

Highlights

• Registry Update: The image repository for the csi-node-driver-registrar has been updated from the deprecated k8s.gcr.io to the new registry.k8s.io.
• Component Upgrade: The csi-node-driver-registrar component has been upgraded to version v2.9.4 from v2.5.0.
• Probe Removal: Unused livenessProbe and readinessProbe configurations have been removed from the model-csi-driver daemonset template, simplifying the deployment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the deprecated k8s.gcr.io registry to registry.k8s.io for the csi-node-driver-registrar image and bumps its version. It also removes unused and broken code for configurable liveness and readiness probes from the daemonset.yaml. The changes are generally positive, but I have a couple of suggestions to improve the robustness and flexibility of the Helm chart.

I am having trouble creating individual review comments. Click here to see my feedback.

charts/model-csi-driver/templates/daemonset.yaml (131-138)

While this block of code was non-functional due to producing a duplicate livenessProbe key, completely removing it also removes the intent of allowing configurable liveness and readiness probes. This reduces the chart's flexibility, as the default liveness probe is very basic and users might require a more sophisticated check.

Consider fixing the templating logic to allow overriding the default probes instead of removing this capability entirely. This would involve conditioning the default probe on .Values.livenessProbe not being set, which would make the chart more robust and customizable.

charts/model-csi-driver/values.yaml (27)

Updating csi-node-driver-registrar to v2.9.4 is a good step to stay current. However, this version has a minimum Kubernetes version requirement (v1.25+). This could be a breaking change for users on older clusters.

To prevent installation on unsupported Kubernetes versions, it's recommended to specify the Kubernetes version compatibility in Chart.yaml using the kubeVersion field. For example:

# In Chart.yaml
apiVersion: v2
name: model-csi-driver
...
kubeVersion: ">= 1.25.0-0"

This will help users avoid runtime errors by having Helm check for compatibility before installation.

[imeoer]

Thanks, LGTM!

[gaius-qi]

LGTM