New methods for mat file delegate reader #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efredriksson-modelon
requested review from
PeterMeisrimelModelon and
hugo-sigurdson
Collaborator
PeterMeisrimelModelon
left a comment
PeterMeisrimelModelon
left a comment
There was a problem hiding this comment.
Looks good! Just a few comment around documentation and tests.
PeterMeisrimelModelon
approved these changes
Jan 15, 2026
efredriksson-modelon
deleted the
dev-ef-new-methods-for-mat-file-delegate-reader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds new methods to the result reader 'ResultReaderBinaryMat' such that it can be used as a drop in replacement for 'ResultDymolaBinary' in many cases.