Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/streamable-http-onclose-types.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@modelcontextprotocol/node': patch
'@modelcontextprotocol/server': patch
---

Align Streamable HTTP onclose types with the shared Transport contract.
4 changes: 2 additions & 2 deletions packages/middleware/node/src/streamableHttp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ export class NodeStreamableHTTPServerTransport implements Transport {
/**
* Sets callback for when the transport is closed.
*/
set onclose(handler: (() => void) | undefined) {
set onclose(handler: Transport['onclose']) {
this._webStandardTransport.onclose = handler;
}

get onclose(): (() => void) | undefined {
get onclose(): Transport['onclose'] {
return this._webStandardTransport.onclose;
}

Expand Down
5 changes: 5 additions & 0 deletions packages/middleware/node/test/streamableHttp.typecheck.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import type { Transport } from '@modelcontextprotocol/core';
import { NodeStreamableHTTPServerTransport } from '../src/streamableHttp.js';

const transport: Transport = new NodeStreamableHTTPServerTransport({});
transport.onclose = undefined;
2 changes: 1 addition & 1 deletion packages/server/src/server/streamableHttp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
private _supportedProtocolVersions: string[];

sessionId?: string;
onclose?: () => void;
onclose?: Transport['onclose'];
onerror?: (error: Error) => void;
onmessage?: (message: JSONRPCMessage, extra?: MessageExtraInfo) => void;

Expand Down
Loading