Skip to content

fix: add | undefined to transport option callbacks for exactOptionalPropertyTypes #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Christian-Sidak wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

fix: add | undefined to transport option callbacks for exactOptionalPropertyTypes #1855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/middleware/node/test/streamableHttp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ interface TestServerConfig {
enableJsonResponse?: boolean;
customRequestHandler?: (req: IncomingMessage, res: ServerResponse, parsedBody?: unknown) => Promise<void>;
eventStore?: EventStore;
onsessioninitialized?: (sessionId: string) => void | Promise<void>;
onsessionclosed?: (sessionId: string) => void | Promise<void>;
onsessioninitialized?: ((sessionId: string) => void | Promise<void>) | undefined;
onsessionclosed?: ((sessionId: string) => void | Promise<void>) | undefined;
retryInterval?: number;
}

Expand Down
10 changes: 5 additions & 5 deletions packages/server/src/server/streamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export interface WebStandardStreamableHTTPServerTransportOptions {
*
* If not provided, session management is disabled (stateless mode).
*/
sessionIdGenerator?: () => string;
sessionIdGenerator?: (() => string) | undefined;

/**
* A callback for session initialization events
Expand All @@ -86,7 +86,7 @@ export interface WebStandardStreamableHTTPServerTransportOptions {
* and need to keep track of them.
* @param sessionId The generated session ID
*/
onsessioninitialized?: (sessionId: string) => void | Promise<void>;
onsessioninitialized?: ((sessionId: string) => void | Promise<void>) | undefined;

/**
* A callback for session close events
Expand All @@ -98,7 +98,7 @@ export interface WebStandardStreamableHTTPServerTransportOptions {
* session open/running.
* @param sessionId The session ID that was closed
*/
onsessionclosed?: (sessionId: string) => void | Promise<void>;
onsessionclosed?: ((sessionId: string) => void | Promise<void>) | undefined;

/**
* If `true`, the server will return JSON responses instead of starting an SSE stream.
Expand Down Expand Up @@ -233,8 +233,8 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
private _enableJsonResponse: boolean = false;
private _standaloneSseStreamId: string = '_GET_stream';
private _eventStore?: EventStore;
private _onsessioninitialized?: (sessionId: string) => void | Promise<void>;
private _onsessionclosed?: (sessionId: string) => void | Promise<void>;
private _onsessioninitialized?: ((sessionId: string) => void | Promise<void>) | undefined;
private _onsessionclosed?: ((sessionId: string) => void | Promise<void>) | undefined;
private _allowedHosts?: string[];
private _allowedOrigins?: string[];
private _enableDnsRebindingProtection: boolean;
Expand Down
Loading