fix(examples): use 404 status for invalid session IDs#1560
Open
corvid-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(examples): use 404 status for invalid session IDs#1560corvid-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
corvid-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Per the MCP spec, servers should respond with 404 when presented with an invalid session ID, so clients know to start a new session. The examples incorrectly used 400 for this case. Closes modelcontextprotocol#389 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
400to404for invalid/missing session ID responses across all streamable HTTP examplesFiles changed
jsonResponseStreamableHttp.ts— POST handlersimpleStreamableHttp.ts— POST, GET, DELETE handlersstandaloneSseWithGetStreamableHttp.ts— POST, GET handlerssimpleTaskInteractive.ts— POST, GET, DELETE handlerselicitationFormExample.ts— POST, GET, DELETE handlerselicitationUrlExample.ts— POST, GET, DELETE handlersCloses #389
Test plan
🤖 Generated with Claude Code