-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(deps): resolve npm audit vulnerabilities and bump dependencies (v1.x backport) #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): resolve npm audit vulnerabilities and bump dependencies (v1.x backport) #1382
Conversation
|
Resolves GHSA-3vhc-576x-3qv4 and GHSA-f67f-6cw9-8mq4 JWT algorithm confusion vulnerabilities by ensuring hono 4.11.4 is installed instead of relying on transitive dependency from @hono/node-server.
commit: |
|
Hi, thank you for this. Since the |
Hi @KKonstantinov 👋🏼, happy to help if I can |
felixweinberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
aa81a66
into
modelcontextprotocol:v1.x
Resolves npm audit security vulnerabilities and updates dependencies to their latest compatible versions for the v1.x release branch.
This is the backport of #1381
Motivation and Context
Running
npm auditon the v1.x branch was reporting multiple high-severity security vulnerabilities:Hono JWT vulnerabilities (GHSA-3vhc-576x-3qv4, GHSA-f67f-6cw9-8mq4):
hono<4.11.4 (transitive dependency via@hono/node-server)@hono/node-serverto ^1.19.9 and addinghono^4.11.4 as a direct dependencyqs package vulnerability:
qsoverridesto forceqs@6.14.1This PR addresses these vulnerabilities by:
@hono/node-serverto ^1.19.9hono^4.11.4 as a direct dependency (resolves Hono JWT vulnerabilities)overridesforqs@6.14.1(resolves qs vulnerability)How Has This Been Tested?
npm auditreports 0 vulnerabilities after this changenpm test- all 1497 tests pass)npm run buildcompletes successfullyBreaking Changes
None. This is a patch release with security fixes and dependency updates only.
Types of changes
Checklist
Additional context
Security fixes:
@hono/node-server(^1.19.7 → ^1.19.9)hono(added as direct dependency at ^4.11.4 to ensure secure version)overridesforqs@6.14.1Dependency updates:
express(^5.0.1 → ^5.2.1)express-rate-limit(^7.5.0 → ^8.2.1)jose(^6.1.1 → ^6.1.3)zod-to-json-schema(^3.23.2 → ^3.25.1)Test fixes:
packages/client/test/client/auth-extensions.test.tsto match jose library's updated error output (changed from/Invalid character/to/cannot be part of a valid base64/)Implementation notes:
honowas added as a direct dependency instead of using npm overrides to ensure the secure version (4.11.4) is always installed, even as@hono/node-serverupdates its transitive dependencies