You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the tool() method with a ZodObject schema like z.object({ message: z.string() }), the SDK was silently treating the schema as annotations instead of a parameter schema.
How Has This Been Tested?
Added some tests to verify that the tool() method handles ZodObject schemas as expected.
Breaking Changes
No breaking changes. This is a backward-compatible bug fix.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Hello, .tool signatures will be removed in v2 effectively - please use registerTool instead (these are deprecated methods). For v1.x, these are also marked as @deprecated. Does the same issue apply to registerTool?
Hi @KKonstantinov, I don't think registerTool has the same issue. The bug only affects tool because of its complex positional argument parsing logic. This fix will prevent silent failures for developers using the idiomatic z.object() syntax with the deprecated tool method until it is removed in v2.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DaleSeo
force-pushed
the
tool-method-zobject-arguments
branch
2 times, most recently
from
Fixes #1291
Motivation and Context
When using the
tool()method with a ZodObject schema likez.object({ message: z.string() }), the SDK was silently treating the schema as annotations instead of a parameter schema.How Has This Been Tested?
Added some tests to verify that the
tool()method handles ZodObject schemas as expected.Breaking Changes
No breaking changes. This is a backward-compatible bug fix.
Types of changes
Checklist
Additional context