Remove excessive conformance of Value.init(:) parameter to Codable#227
Open
samkudr wants to merge 1 commit into
Open
Remove excessive conformance of Value.init(:) parameter to Codable#227samkudr wants to merge 1 commit into
samkudr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value.init(:)requires its parameter to conform toCodablebut actually it needs justEncodablevalue.Motivation and Context
The current requirement is literally excessive: the initializer encodes the incoming value to
Value, the same wayJSONEncoderencodes the incoming value toData.How Has This Been Tested?
In my project I was forced to extend conformance of some types to
Decodablealso, while knowing that it is never used.Breaking Changes
No.
Types of changes
Checklist
Additional context