fix: detached frame error & feature: Puppeteer launch arguments support#607
Merged
olaservo merged 2 commits intomodelcontextprotocol:mainfrom Mar 30, 2025
Merged
fix: detached frame error & feature: Puppeteer launch arguments support#607olaservo merged 2 commits intomodelcontextprotocol:mainfrom
olaservo merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
|
I have this issue, is the fix going to be merged ? |
olaservo
requested changes
Mar 29, 2025
Member
olaservo
left a comment
There was a problem hiding this comment.
Thanks for fixing the detached frame error and for adding args support! If we do include the args input here as well, could you also add a note to the Readme about this feature, something like:
### Launch Arguments
The server supports configuring Puppeteer launch options:
- **headless** (boolean): Run browser in headless mode
Example:
```json
{
"url": "https://example.com",
"args": {
"headless": true
}
}
olaservo
reviewed
Mar 30, 2025
Member
|
I think besides the potential edge case I mentioned this is looking good and I will keep an eye out to merge. |
olaservo
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detached Frame Error Fix and Puppeteer Launch Arguments Support
Description
This PR fixes the "detached Frame" error (
MCP error -32603: Attempted to use detached Frame 'D9B4203EF8575FD5A6ABAFC77F0F8E18') encountered in the MCP tool. Additionally, it adds support for specifying Puppeteer launch arguments, improving flexibility when initializing browser instances.Server Details
modelcontextprotocol/serversMotivation and Context
How Has This Been Tested?
Breaking Changes
Types of Changes
Checklist
Additional Context