Skip to content

Conversation

@olaservo
Copy link
Member

@olaservo olaservo commented Jul 17, 2025

@olaservo olaservo marked this pull request as ready for review July 17, 2025 23:47
@olaservo olaservo requested review from cliffhall and tadasant July 17, 2025 23:47
@olaservo olaservo enabled auto-merge July 18, 2025 22:16
@cliffhall
Copy link
Member

@olaservo I added a comment on the FixParser PR, as the page at the link address doesn't offer any information on the MCP server configuration or use. Generally we have required that as a minimum. If you want to remove that one from this PR, I'll approve and merge after vetting the rest of the servers.

@fixparser
Copy link
Contributor

@olaservo I added a comment on the FixParser PR, as the page at the link address doesn't offer any information on the MCP server configuration or use. Generally we have required that as a minimum. If you want to remove that one from this PR, I'll approve and merge after vetting the rest of the servers.

The FIXParser repo is a monorepo, and the MCP package does have basic docs here: https://gitlab.com/logotype/fixparser/-/tree/dev/packages/fixparser-plugin-mcp

@cliffhall
Copy link
Member

The FIXParser repo is a monorepo, and the MCP package does have basic docs here: https://gitlab.com/logotype/fixparser/-/tree/dev/packages/fixparser-plugin-mcp

Then please update your PR to point to the MCP documentation rather than the top of the repo.

@fixparser
Copy link
Contributor

The FIXParser repo is a monorepo, and the MCP package does have basic docs here: https://gitlab.com/logotype/fixparser/-/tree/dev/packages/fixparser-plugin-mcp

Then please update your PR to point to the MCP documentation rather than the top of the repo.

thank you, links has been updated.

@binggg
Copy link

binggg commented Jul 22, 2025

Hi @olaservo
I noticed a small typo in my PR. The URL for Tencent CloudBase should be corrected from:Tencent CloudBaseto:Tencent CloudBaseCould we please update this? Thanks for your help!

@olaservo
Copy link
Member Author

Hi @olaservo
I noticed a small typo in my PR. The URL for Tencent CloudBase should be corrected from:Tencent CloudBaseto:Tencent CloudBase

@binggg done!

@olaservo
Copy link
Member Author

@fixparser @cliffhall I just ended up merging the original PR separately and removing from this description, since that was simpler.

@fixparser
Copy link
Contributor

fixparser commented Jul 22, 2025

@olaservo thanks! have a great day!

Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants