Skip to content

Standardize build and binary references for server-redis#1426

Merged
olaservo merged 6 commits intomodelcontextprotocol:mainfrom
olaservo:fix-redis-server-binary
Apr 18, 2025
Merged

Standardize build and binary references for server-redis#1426
olaservo merged 6 commits intomodelcontextprotocol:mainfrom
olaservo:fix-redis-server-binary

Conversation

@olaservo
Copy link
Member

Description

There are a couple leftover quirks in the redis server example to resolve, since the npx command was able to find the package now, but I was still having connection issues that I wasn't seeing when testing the local build.

Server Details

  • Server: redis
  • Changes to: build and binary

Motivation and Context

I noticed that although the local build of server-redis was working, I was still having trouble running it through npx.

There are a couple other changes here that are not 100% needed to solve the issue, but should make it more consistent with other reference typescript servers.

How Has This Been Tested?

This time I published an experimental version under my own npm user/alias and installed it using npx in Claude Desktop.

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

@olaservo olaservo requested a review from tadasant April 15, 2025 12:42
tadasant
tadasant previously approved these changes Apr 15, 2025
Copy link
Member

@tadasant tadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a light review and passes sense checks -- I think it's a low risk change given the server is in a non-working state, but do let me know if you need me to take a closer look for a more informed opinion on some piece of this.

Thank you for tackling this!

@olaservo
Copy link
Member Author

olaservo commented Apr 18, 2025

@tadasant btw no major changes since your last approval just added more logs while troubleshooting a local connection, and added a few more troubleshooting notes to the Readme. Edit: also package-lock hadn't been updated.

@olaservo olaservo added server-redis bug Something isn't working labels Apr 18, 2025
@olaservo olaservo merged commit fc99b57 into modelcontextprotocol:main Apr 18, 2025
25 checks passed
@olaservo olaservo mentioned this pull request Apr 18, 2025
12 tasks
PazerOP referenced this pull request in PazerOP/mcp-template Jul 15, 2025
Standardize build and binary references for server-redis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants