Standardize build and binary references for server-redis#1426
Merged
olaservo merged 6 commits intomodelcontextprotocol:mainfrom Apr 18, 2025
Merged
Standardize build and binary references for server-redis#1426olaservo merged 6 commits intomodelcontextprotocol:mainfrom
olaservo merged 6 commits intomodelcontextprotocol:mainfrom
Conversation
tadasant
previously approved these changes
Apr 15, 2025
Member
There was a problem hiding this comment.
Did a light review and passes sense checks -- I think it's a low risk change given the server is in a non-working state, but do let me know if you need me to take a closer look for a more informed opinion on some piece of this.
Thank you for tackling this!
Member
Author
|
@tadasant btw no major changes since your last approval just added more logs while troubleshooting a local connection, and added a few more troubleshooting notes to the Readme. Edit: also package-lock hadn't been updated. |
tadasant
approved these changes
Apr 18, 2025
12 tasks
PazerOP
referenced
this pull request
in PazerOP/mcp-template
Jul 15, 2025
Standardize build and binary references for server-redis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are a couple leftover quirks in the redis server example to resolve, since the npx command was able to find the package now, but I was still having connection issues that I wasn't seeing when testing the local build.
Server Details
Motivation and Context
I noticed that although the local build of server-redis was working, I was still having trouble running it through
npx.There are a couple other changes here that are not 100% needed to solve the issue, but should make it more consistent with other reference typescript servers.
How Has This Been Tested?
This time I published an experimental version under my own npm user/alias and installed it using npx in Claude Desktop.
Breaking Changes
None
Types of changes
Checklist