Fix non IANA timezone in Time server#1272
Closed
ababino wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
Fix non IANA timezone in Time server#1272ababino wants to merge 3 commits intomodelcontextprotocol:mainfrom
ababino wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
…offsets and improve error handling
… handling and streamline logic for matching IANA timezones based on UTC offset
Member
|
Thanks for the PR! I wonder if we should incorporate the tzlocal approach from 925 as the primary approach and then do fallbacks in this order: First attempt to use First fallback: Try direct ZoneInfo conversion, for cases where a valid IANA name is provided Final fallback: Then use UTC offset matching like you have in this PR, to handle the remaining scenarios What do you think? |
12 tasks
13 tasks
Member
|
Superceded by #1761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If system timezone is not in the IANA standard, these changes will set the timezone based on the UTC offset.
This fixes #489, #612, and #786.
The solution is better than PR #925 because it will not fail even if
datetime.now()tzoneis not IANA.The solution is also better than PR #320 because it does not relies on hardcoded mappings.
Server Details
Motivation and Context
It doesn't work with my local setup unless the
--local-timezoneflag is specified.How Has This Been Tested?
With Claude Desktop
Breaking Changes
No
Types of changes
Checklist
Additional context