GitHub MCP server: Allow null label descriptions#1102
Closed
daninfpj wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
GitHub MCP server: Allow null label descriptions#1102daninfpj wants to merge 3 commits intomodelcontextprotocol:mainfrom
daninfpj wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
Member
|
This duplicate PR was just merged: #694 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1101
Fix GitHub label schema to handle null descriptions.
Description
Updates the
GitHubLabelSchemato properly handle label descriptions that can be null. The GitHub API can return labels with null descriptions, but the current schema only allows string values or omitted fields. This PR updates the schema to support all possible API responses.Server Details
Motivation and Context
The GitHub API can return labels with null descriptions, but our current schema validation fails in these cases. This causes the
get_pull_requesttool to fail when processing pull requests that contain labels with null descriptions.Example error:
{"error":"MCP error -32603: Invalid input: [{\"code\":\"invalid_type\",\"expected\":\"string\",\"received\":\"null\",\"path\":[\"labels\",1,\"description\"],\"message\":\"Expected string, received null\"}]"}How Has This Been Tested?
get_pull_requesttool successfully processes all casesGitHubLabelSchema(likelist_issues) continue to work correctlyBreaking Changes
No breaking changes. This is a more permissive schema that accepts all valid GitHub API responses.
Types of changes
Checklist