Open
Conversation
github-actions
bot
added
T-test
DaleSeo
reviewed
Mar 26, 2026
| #[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Copy)] | ||
| #[serde(rename_all = "lowercase")] //match spec | ||
| #[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))] | ||
| pub enum IconTheme { |
Member
There was a problem hiding this comment.
The MCP spec could add more themes in the future (e.g., high-contrast). This would prevent downstream match arms from breaking when new variants are added.
Suggested change
| pub enum IconTheme { | |
| #[non_exhaustive] | |
| pub enum IconTheme { |
| } | ||
|
|
||
| /// Icon themes supported by the MCP specification | ||
| #[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Copy)] |
Member
There was a problem hiding this comment.
Adding these would let consumers use it as a HashMap key or in HashSet without friction.
Suggested change
| #[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Copy)] | |
| #[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq, Hash, Copy)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add the "theme" field to Icon struct as defined in the MCP Spec: https://modelcontextprotocol.io/specification/2025-11-25/schema#icon . Clients and Servers can use this field now.
How Has This Been Tested?
Updated unit tests to include the theme field. All tests pass.
Breaking Changes
No
Types of changes
Checklist
Additional context