Skip to content

Use valid syntax for URIs in examples and tests #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atesgoral merged 1 commit into from
Jul 27, 2025
Merged

Use valid syntax for URIs in examples and tests #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/http_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def template(args, server_context:)
prompts: [ExamplePrompt],
resources: [
MCP::Resource.new(
uri: "test_resource",
uri: "https://test_resource.invalid",
name: "Test resource",
description: "Test resource that echoes back the uri as its content",
mime_type: "text/plain",
Expand Down
2 changes: 1 addition & 1 deletion examples/stdio_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def template(args, server_context:)
prompts: [ExamplePrompt],
resources: [
MCP::Resource.new(
uri: "test_resource",
uri: "https://test_resource.invalid",
name: "Test resource",
description: "Test resource that echoes back the uri as its content",
mime_type: "text/plain",
Expand Down
2 changes: 1 addition & 1 deletion test/mcp/server/transports/stdio_notification_integration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def puts(message)
# Add a resource and notify
@server.resources = [
MCP::Resource.new(
uri: "test://resource",
uri: "https://test_resource.invalid",
name: "Test Resource",
description: "A test resource",
mime_type: "text/plain",
Expand Down
16 changes: 8 additions & 8 deletions test/mcp/server_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ class ServerTest < ActiveSupport::TestCase
end

@resource = Resource.new(
uri: "test_resource",
uri: "https://test_resource.invalid",
name: "Test resource",
description: "Test resource",
mime_type: "text/plain",
)

@resource_template = ResourceTemplate.new(
uri_template: "test_resource/{id}",
uri_template: "https://test_resource.invalid/{id}",
name: "Test resource",
description: "Test resource",
mime_type: "text/plain",
Expand Down Expand Up @@ -532,7 +532,7 @@ def call(message:, server_context: nil)

test "#resources_list_handler sets the resources/list handler" do
@server.resources_list_handler do
[{ uri: "test_resource", name: "Test resource", description: "Test resource" }]
[{ uri: "https://test_resource.invalid", name: "Test resource", description: "Test resource" }]
end

request = {
Expand All @@ -543,7 +543,7 @@ def call(message:, server_context: nil)

response = @server.handle(request)
assert_equal(
{ resources: [{ uri: "test_resource", name: "Test resource", description: "Test resource" }] },
{ resources: [{ uri: "https://test_resource.invalid", name: "Test resource", description: "Test resource" }] },
response[:result],
)
assert_instrumentation_data({ method: "resources/list" })
Expand All @@ -555,13 +555,13 @@ def call(message:, server_context: nil)
method: "resources/read",
id: 1,
params: {
uri: "example.com",
uri: "https://test_resource.invalid",
},
}

response = @server.handle(request)
assert_equal({ contents: [] }, response[:result])
assert_instrumentation_data({ method: "resources/read", resource_uri: "example.com" })
assert_instrumentation_data({ method: "resources/read", resource_uri: "https://test_resource.invalid" })
end

test "#resources_read_handler sets the resources/read handler" do
Expand All @@ -578,13 +578,13 @@ def call(message:, server_context: nil)
method: "resources/read",
id: 1,
params: {
uri: "example.com/my_resource",
uri: "https://test_resource.invalid/my_resource",
},
}

response = @server.handle(request)
assert_equal(
{ contents: { uri: "example.com/my_resource", mimeType: "text/plain", text: "Lorem ipsum dolor sit amet" } },
{ contents: { uri: "https://test_resource.invalid/my_resource", mimeType: "text/plain", text: "Lorem ipsum dolor sit amet" } },
response[:result],
)
end
Expand Down