Remove duplicate method instrumentation
#64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes duplicate calls to
add_instrumentation_data(method: ...).Motivation and Context
handle_requestalready adds themethodto the instrumentation data, so there is no need to repeat this. Moreover, consumers can override these anyway.How Has This Been Tested?
This is covered by existing tests.
Breaking Changes
Types of changes
There is no visible change, just a reduction in duplicate work.
Checklist
I have added appropriate error handlingN/AI have added or updated documentation as neededN/AAdditional context
I left behind some calls to
add_instrumentation_datawhich could have been moved.I wasn't sure if we wanted all reads to unconditionally instrument the URI.
I wasn't sure if we wanted to unconditionally instrument the
tool_name, or only instrument known tools (as we do now).Likewise, I wasn't sure if we only want to instrument known prompts.