Suppress redundant attributes in Resources #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the specification, the following attributes are optional, so using `compact` ensures consistency. - `description`: Optional description - `mimeType`: Optional MIME type - `size`: Optional size in bytes https://modelcontextprotocol.io/specification/2025-03-26/server/resources#resource
koic
force-pushed
the
suppress_redundant_attributes_in_resources
branch
from
1d9533c to
2f354a8
Compare
atesgoral
approved these changes
May 30, 2025
koic
added a commit
to koic/ruby-sdk
that referenced
this pull request
May 31, 2025
…ource` This change is related to modelcontextprotocol#29. According to the specification, both `description` and `mimeType` of Resource are optional: https://modelcontextprotocol.io/specification/2025-03-26/server/resources#resource Therefore, it makes sense to treat them as optional keyword arguments, similar to how this is done in `ResourceTemplate`: https://github.com/modelcontextprotocol/ruby-sdk/blob/0b49c3/lib/mcp/resource_template.rb#L8 As additional context, the TypeScript SDK also treats them as optional. https://github.com/modelcontextprotocol/typescript-sdk/blob/1.12.1/src/types.ts#L438-L466
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
According to the specification, the following attributes are optional, so using
compactensures consistency.description: Optional descriptionmimeType: Optional MIME typesize: Optional size in byteshttps://modelcontextprotocol.io/specification/2025-03-26/server/resources#resource
Types of changes
Checklist