Remove dead code in handle_regular_request#256
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Remove dead code in handle_regular_request#256koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
handle_regular_request#256koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Notifications never reach `handle_regular_request` because `handle_post` checks `notification?(body)` first and returns 202 via `handle_accepted`. Since only notifications cause `handle_json` to return `nil`, `response` is always non-`nil` here.
atesgoral
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Notifications never reach
handle_regular_requestbecausehandle_postchecksnotification?(body)first and returns 202 viahandle_accepted. Since only notifications causehandle_jsonto returnnil,responseis always non-nilhere.How Has This Been Tested?
All existing tests pass unchanged.
Breaking Changes
None.
Types of changes
Checklist