Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented Aug 27, 2025

Motivation and Context

The tests related to MCP::Tool::Annotations will be extracted from the MCP::ToolTest test class into a dedicated MCP::Tool::AnnotationsTest unit test class as a testing pair.

This improves test clarity, file level test independence, and file level execution speed. It also ensures consistent placement as a testing pair under MCP::Tool::*:

$ ls lib/mcp/tool/
annotations.rb  input_schema.rb  response.rb
$ ls test/mcp/tool/
annotations_test.rb  input_schema_test.rb  response_test.rb

How Has This Been Tested?

The same number of tests as before are being executed.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

The tests related to `MCP::Tool::Annotations` will be extracted from the `MCP::ToolTest` test class
into a dedicated `MCP::Tool::AnnotationsTest` unit test class as a testing pair.

This improves test clarity, file level test independence, and file level execution speed.
It also ensures consistent placement as a testing pair under `MCP::Tool::*`:

```console
$ ls lib/mcp/tool/
annotations.rb  input_schema.rb  response.rb
$ ls test/mcp/tool/
annotations_test.rb  input_schema_test.rb  response_test.rb
```
@koic koic merged commit 9486c63 into modelcontextprotocol:main Aug 27, 2025
5 checks passed
@koic koic deleted the extract_tool_annotations_tests branch August 27, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants