Conversation
Kludex
commented
Apr 3, 2026
| async def mcp_proxy( | ||
| transport_to_client: MessageStream, | ||
| transport_to_server: MessageStream, | ||
| on_error: ErrorHandler | None = None, |
Member
Author
There was a problem hiding this comment.
Suggested change
| on_error: ErrorHandler | None = None, | |
| *, | |
| on_error: ErrorHandler | None = None, |
Kludex
commented
Apr 3, 2026
Comment on lines
+62
to
+67
| try: | ||
| result = on_error(error) | ||
| if inspect.isawaitable(result): | ||
| await result | ||
| except Exception: | ||
| return |
Member
Author
There was a problem hiding this comment.
I think we have an internal function somewhere to see if it's coroutine or awaitable. Please use that, and we should use to_thread.run_sync to avoid blocking the event loop.
Kludex
commented
Apr 3, 2026
| print(weather.content[0].text) | ||
| print(alerts.content[0].text) | ||
|
|
||
| upstream_server.should_exit = True |
Kludex
commented
Apr 3, 2026
Member
Author
There was a problem hiding this comment.
We don't want a new file! Isn't this implemented somewhere in this repo already?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_proxy()helper inmcp/proxy.pyand export it frommcpon_errorAPIWhy
PR #1763 was closed after accumulating review feedback. This reimplements the proxy from current
mainwhile applying the requested changes:mcp/proxy.pypragma: no coveradditionstype: ignoreassertions in testsTesting
uv run pytest tests/test_proxy.py -qUV_CACHE_DIR=/tmp/uv-cache uv run ruff check src/mcp/proxy.py tests/test_proxy.pyUV_CACHE_DIR=/tmp/uv-cache uv run pyright src/mcp/proxy.py tests/test_proxy.py