Skip to content

feat: support progress_callback propagation in ClientSession (issue #1248) #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nkaushal99 wants to merge 2 commits into from
Closed

feat: support progress_callback propagation in ClientSession (issue #1248) #1249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc73df7
feat: support progress_callback propagation in ClientSession (issue #…
nkaushal99 Aug 7, 2025
6cede19
Merge branch 'main' into progress-callback
felixweinberger Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/mcp/client/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def __init__(
read_stream: MemoryObjectReceiveStream[SessionMessage | Exception],
write_stream: MemoryObjectSendStream[SessionMessage],
read_timeout_seconds: timedelta | None = None,
progress_callback: ProgressFnT | None = None,
sampling_callback: SamplingFnT | None = None,
elicitation_callback: ElicitationFnT | None = None,
list_roots_callback: ListRootsFnT | None = None,
Expand All @@ -127,6 +128,7 @@ def __init__(
read_timeout_seconds=read_timeout_seconds,
)
self._client_info = client_info or DEFAULT_CLIENT_INFO
self._progress_callback = progress_callback
Copy link
Contributor

@felixweinberger felixweinberger Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have a _default_progress_callback?

self._sampling_callback = sampling_callback or _default_sampling_callback
self._elicitation_callback = elicitation_callback or _default_elicitation_callback
self._list_roots_callback = list_roots_callback or _default_list_roots_callback
Expand Down Expand Up @@ -287,7 +289,7 @@ async def call_tool(
),
types.CallToolResult,
request_read_timeout_seconds=read_timeout_seconds,
progress_callback=progress_callback,
progress_callback=progress_callback or self._progress_callback,
Copy link
Contributor

@felixweinberger felixweinberger Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it's just inviting hard to debug behavior where we make a call_tool call without any progress_callback yet there still somehow ends up being one via some separate state object.

)

if not result.isError:
Expand Down
Loading