fix: Resolve critical CI hanging issues with minimal changes #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core fixes to address CI hanging for hours: 1. **CLI Dependencies**: Add --group dev to uv sync commands - Prevents ModuleNotFoundError during pytest collection - This was the primary cause of infinite CI hangs 2. **Global Timeout Protection**: Add 60s timeout to all tests - Prevents tests from running indefinitely - Add pytest-timeout>=2.1.0 dependency 3. **Windows Integration Test Strategy**: Split test execution - Run integration tests sequentially on Windows (--numprocesses 1) - Run other tests in parallel (--numprocesses auto) - Add integration marker for multiprocessing tests 4. **CI Timeout**: Increase timeout-minutes from 10 to 15 These minimal changes address the core issues without broad scope.
Member
|
Which jobs hang for hours? |
Contributor
|
@spacelord16 thanks for your contribution! I'm closing this PR for now as it's been a while since @Kludex' review and we haven't received further information that this is an issue - as far as I can tell I haven't seen any jobs hanging in CI for hours (there are occasional flakes, but these tend to materialize quickly). Feel free to reopen or resubmit if you believe this is still an issue - if so, would love to see links to specific CI jobs or runs where you saw this crop up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core fixes to address CI hanging for hours:
CLI Dependencies: Add --group dev to uv sync commands
Global Timeout Protection: Add 60s timeout to all tests
Windows Integration Test Strategy: Split test execution
CI Timeout: Increase timeout-minutes from 10 to 15
These minimal changes address the core issues without broad scope.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context